Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: cherry pick for 0.14.2 #1646

Merged
merged 1 commit into from
Jan 26, 2024
Merged

sync: cherry pick for 0.14.2 #1646

merged 1 commit into from
Jan 26, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 26, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherry picks #1645 from master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
fix(userspace/libsinsp): revert to old concatenate_paths helper fun…
a46509f 
…ction for perf reasons.

Also, added some small fixes and lots of new tests.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP changed the base branch from master to release/0.14.x January 26, 2024 09:09
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 26, 2024

/milestone 0.14.2

@poiana poiana requested review from hbrueckner and incertum January 26, 2024 09:09
@poiana poiana added this to the 0.14.2 milestone Jan 26, 2024
@FedeDP FedeDP changed the title chore: cherry pick for 0.14.2 sync: cherry pick for 0.14.2 Jan 26, 2024
jasondellaluce
jasondellaluce approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jan 26, 2024
@poiana
Copy link
Contributor

poiana commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 26, 2024

Why jobs are not triggering? Trying to close and reopne.
/close

@poiana poiana closed this Jan 26, 2024
@poiana
Copy link
Contributor

poiana commented Jan 26, 2024

@FedeDP: Closed this PR.

In response to this:

Why jobs are not triggering? Trying to close and reopne.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 26, 2024

/reopen

@poiana poiana reopened this Jan 26, 2024
@poiana
Copy link
Contributor

poiana commented Jan 26, 2024

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 26, 2024

STARTED!

@poiana poiana merged commit ff39fd3 into release/0.14.x Jan 26, 2024
31 checks passed
@poiana poiana deleted the chore/cherry_pick_0142 branch January 26, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@leogr leogr leogr approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@incertum incertum Awaiting requested review from incertum

Assignees

@leogr leogr

@jasondellaluce jasondellaluce

@LucaGuerra LucaGuerra

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup lgtm release-note-none size/L
Projects
None yet
Milestone
0.14.2
Development

Successfully merging this pull request may close these issues.
5 participants
@FedeDP @poiana @leogr @jasondellaluce @LucaGuerra